feat: codspeed go add perf v2 support #18

not-matthias · 2025-09-29T17:35:57Z

Fixed some unrelated bugs that I discovered while working on this:

Run benchmarks of all packages (./...) with optimized go-runner (previously it only ran benches in . with debug go-runner)
b.N loops were slow because we tried to convert benchTime (which was already in seconds) to seconds
https://github.com/CodSpeedHQ/codspeed-go/pull/18/commits

Other changes:

Added an example to ensure we handle ResetTimer
Add benchmark marker support (had to disable pausing the timer in b.Loop() due to the extra overhead)

Copilot

Pull Request Overview

This PR adds CodSpeed Go performance v2 support by integrating benchmark timing markers and updating the underlying instrument-hooks dependency.

Adds new benchmark timing functionality using start/end timestamps to track performance measurements
Updates the instrument-hooks commit to a newer version that supports the v2 performance API
Introduces new marker types and timing functions for enhanced benchmark instrumentation

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File	Description
testing/testing/benchmark.go	Adds startTimestamp field and integrates benchmark timing markers in StartTimer/StopTimer methods
testing/capi/vendor.sh	Updates instrument-hooks commit hash to newer version with v2 support
testing/capi/instrument-hooks/includes/core.h	Adds new marker type constants and function declarations for timestamp handling
testing/capi/instrument-hooks.go	Implements Go bindings for new timestamp and marker functionality

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

testing/capi/instrument-hooks.go

avalanche-staging · 2025-10-02T16:15:59Z

CodSpeed Performance Report

Merging #18 will not alter performance

_{Comparing cod-1378-codspeed-go-add-perf-v2-support (8ee14f6) with main (d7de44a)}

Summary

✅ 8 untouched
🆕 16 new
⏩ 14 skipped¹

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Change
🆕	`BenchmarkLargeSetup`	N/A	9.8 ms	N/A
🆕	`BenchmarkLargeSetupInLoop`	N/A	24 ns	N/A
🆕	`BenchmarkSleep100ns`	N/A	233 ns	N/A
🆕	`BenchmarkSleep100ns_Loop`	N/A	240 ns	N/A
🆕	`BenchmarkSleep100us`	N/A	100.2 µs	N/A
🆕	`BenchmarkSleep100us_Loop`	N/A	100.2 µs	N/A
🆕	`BenchmarkSleep10ms`	N/A	10 ms	N/A
🆕	`BenchmarkSleep10ms_Loop`	N/A	10 ms	N/A
🆕	`BenchmarkSleep10us`	N/A	10.2 µs	N/A
🆕	`BenchmarkSleep10us_Loop`	N/A	10.2 µs	N/A
🆕	`BenchmarkSleep1ms`	N/A	1 ms	N/A
🆕	`BenchmarkSleep1ms_Loop`	N/A	1 ms	N/A
🆕	`BenchmarkSleep1us`	N/A	1.2 µs	N/A
🆕	`BenchmarkSleep1us_Loop`	N/A	1.2 µs	N/A
🆕	`BenchmarkSleep50ms`	N/A	50 ms	N/A
🆕	`BenchmarkSleep50ms_Loop`	N/A	50 ms	N/A

14 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copilot

Pull Request Overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

testing/testing/benchmark.go

art049 · 2025-10-06T14:23:28Z

@not-matthias don't forget to archive the removed benchmarks since you changed the folder

art049

LGTM

art049 · 2025-10-06T14:21:37Z

testing/capi/instrument-hooks.go

+const (
+	MarkerTypeSampleStart    = 0
+	MarkerTypeSampleEnd      = 1
+	MarkerTypeBenchmarkStart = 2
+	MarkerTypeBenchmarkEnd   = 3
+)


same feedback as in the Python PR, if there is a way to avoid duplicating this, it would be great

not-matthias requested a review from Copilot September 29, 2025 17:36

Copilot AI reviewed Sep 29, 2025

View reviewed changes

testing/capi/instrument-hooks.go Outdated Show resolved Hide resolved

not-matthias force-pushed the cod-1378-codspeed-go-add-perf-v2-support branch from 7685745 to b3beed3 Compare September 29, 2025 17:36

avalanche-staging bot deleted a comment from codspeed-hq bot Oct 2, 2025

not-matthias force-pushed the cod-1378-codspeed-go-add-perf-v2-support branch from 541b758 to 10f3008 Compare October 2, 2025 16:22

not-matthias added 2 commits October 2, 2025 18:23

fix(ci): run go-runner in release mode

e4cc76c

fix(ci): run benchmarks of all packages

58d4242

not-matthias force-pushed the cod-1378-codspeed-go-add-perf-v2-support branch from 10f3008 to 574f624 Compare October 2, 2025 16:46

not-matthias requested a review from Copilot October 2, 2025 16:46

Copilot AI reviewed Oct 2, 2025

View reviewed changes

testing/testing/benchmark.go Show resolved Hide resolved

testing/testing/benchmark.go Outdated Show resolved Hide resolved

testing/testing/benchmark.go Show resolved Hide resolved

not-matthias force-pushed the cod-1378-codspeed-go-add-perf-v2-support branch 2 times, most recently from 546ac8a to d405bf5 Compare October 2, 2025 16:55

not-matthias requested a review from art049 October 3, 2025 08:27

not-matthias force-pushed the cod-1378-codspeed-go-add-perf-v2-support branch from f5d2d6f to c19b2fb Compare October 3, 2025 12:13

not-matthias added 6 commits October 3, 2025 15:36

feat(example): add bench with setup

45673f9

fix(ci): use sharded walltime runs

fde54be

fix(example): move sleep tests to own package

c096497

fix(testing): benchTime is already in seconds

9eff5c9

fix(testing): remove wrong reset timer

7cc4b44

chore(testing): bump instrument-hooks

e674755

not-matthias force-pushed the cod-1378-codspeed-go-add-perf-v2-support branch 2 times, most recently from 416dc8a to 7cd5115 Compare October 3, 2025 13:43

avalanche-staging bot deleted a comment from codspeed-hq bot Oct 3, 2025

not-matthias force-pushed the cod-1378-codspeed-go-add-perf-v2-support branch from cc154a3 to 7cd5115 Compare October 3, 2025 14:59

not-matthias added 2 commits October 3, 2025 19:10

fix(testing): dont append to list before stopping testing timer

944050f

feat(testing): add benchmark markers

8ee14f6

not-matthias force-pushed the cod-1378-codspeed-go-add-perf-v2-support branch from 7cd5115 to 8ee14f6 Compare October 3, 2025 17:22

art049 approved these changes Oct 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: codspeed go add perf v2 support #18

feat: codspeed go add perf v2 support #18

Uh oh!

not-matthias commented Sep 29, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

avalanche-staging bot commented Oct 2, 2025 •

edited by codspeed-hq bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

art049 commented Oct 6, 2025

Uh oh!

art049 left a comment

Uh oh!

art049 Oct 6, 2025

Uh oh!

Uh oh!

feat: codspeed go add perf v2 support #18

Are you sure you want to change the base?

feat: codspeed go add perf v2 support #18

Uh oh!

Conversation

not-matthias commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

avalanche-staging bot commented Oct 2, 2025 • edited by codspeed-hq bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #18 will not alter performance

Summary

Benchmarks breakdown

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

art049 commented Oct 6, 2025

Uh oh!

art049 left a comment

Choose a reason for hiding this comment

Uh oh!

art049 Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

not-matthias commented Sep 29, 2025 •

edited

Loading

avalanche-staging bot commented Oct 2, 2025 •

edited by codspeed-hq bot

Loading